feat: support skipping prompts for installing GUI dependencies #395
Conversation
Signed-off-by: Stephen Crowe <[email protected]>
There was a problem hiding this comment.
We have some lessons learned with the regular deadline bundle submit command that a --yes/-y for these bigger workflows that can have multiple prompts does not work well. It's not obvious what the --yes should be choosing if a default is not affirmative. It begins to become arbitrary as you force your way through the flow and you lose fine-grained control of those choices.
After the first-use, the -y isn't even used for anything since the user won't be prompted again.
Instead, what are your thoughts about doing something like --ensure-gui? This way we can still bypass this by choosing ahead of time that we will accept the "do you want to install the gui" prompt without confusing it with other prompts/options
Signed-off-by: Stephen Crowe <[email protected]>
…eadline#395) * feat: support skipping prompts for installing GUI dependencies Signed-off-by: Stephen Crowe <[email protected]>
…eadline#395) * feat: support skipping prompts for installing GUI dependencies Signed-off-by: Stephen Crowe <[email protected]> Signed-off-by: Cloud User <[email protected]>
…eadline#395) * feat: support skipping prompts for installing GUI dependencies Signed-off-by: Stephen Crowe <[email protected]> Signed-off-by: Cloud User <[email protected]>
What was the problem/requirement? (What/Why)
DCM should be able to invoke
deadline bundle gui-submitnon-CLI users can still submit bundles. But if the GUI dependencies aren't already installed, the command will hang until the prompt about installing GUI dependencies is answered.What was the solution? (How)
Support a
--install-guiflag that skips the prompt.What is the impact of this change?
DCM can invoke the bundle submitter more reliably.
How was this change tested?
By uninstalling PySide and then calling
deadline bundle gui-submitanddeadline config guiwith and without the--install-guiflag.Was this change documented?
Yes - in the CLI help.
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.